Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Fix missing aria-label in pagenavigation #3202

Closed
jgerman-bot opened this issue Jun 15, 2024 · 1 comment · Fixed by #3203
Closed

[a11y] Fix missing aria-label in pagenavigation #3202

jgerman-bot opened this issue Jun 15, 2024 · 1 comment · Fixed by #3203

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#43600 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/plg_content_pagenavigation.ini b/administrator/language/en-GB/plg_content_pagenavigation.ini
index ae698f5398d5b..5b7f4f6ff3f2a 100644
--- a/administrator/language/en-GB/plg_content_pagenavigation.ini
+++ b/administrator/language/en-GB/plg_content_pagenavigation.ini
@@ -4,6 +4,7 @@
 ; Note : All ini files need to be saved as UTF-8
 
 PLG_CONTENT_PAGENAVIGATION="Content - Page Navigation"
+PLG_PAGENAVIGATION_ARIA_LABEL="Page Navigation"
 PLG_PAGENAVIGATION_FIELD_DISPLAY_LABEL="Link Text"
 PLG_PAGENAVIGATION_FIELD_POSITION_LABEL="Position"
 PLG_PAGENAVIGATION_FIELD_RELATIVE_LABEL="Relative To"
diff --git a/plugins/content/pagenavigation/tmpl/default.php b/plugins/content/pagenavigation/tmpl/default.php
index 1245c39e3d4ac..d9b8bcc5d7a50 100644
--- a/plugins/content/pagenavigation/tmpl/default.php
+++ b/plugins/content/pagenavigation/tmpl/default.php
@@ -13,10 +13,12 @@
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\Router\Route;
 
+$this->loadLanguage();
+
 $lang = $this->getLanguage();
 ?>
 
-<nav class="pagenavigation">
+<nav class="pagenavigation" aria-label="<?php echo Text::_('PLG_PAGENAVIGATION_ARIA_LABEL'); ?>">
     <span class="pagination ms-0">
     <?php if ($row->prev) :
         $direction = $lang->isRtl() ? 'right' : 'left'; ?>
@zero-24
Copy link
Member

zero-24 commented Jun 16, 2024

PR #3203

@zero-24 zero-24 closed this as completed Jun 16, 2024
@zero-24 zero-24 linked a pull request Jun 16, 2024 that will close this issue
tecpromotion added a commit that referenced this issue Jun 16, 2024
[a11y] Fix missing aria-label in pagenavigation #3202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants