Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symfony/console 5.x #129

Closed
stevenrombauts opened this issue Aug 31, 2020 · 2 comments · Fixed by #130
Closed

Support symfony/console 5.x #129

stevenrombauts opened this issue Aug 31, 2020 · 2 comments · Fixed by #130
Assignees
Milestone

Comments

@stevenrombauts
Copy link
Member

stevenrombauts commented Aug 31, 2020

Add initial support for symfony/console ^5.0

Todo's:

  • Update folioshell too
@stevenrombauts
Copy link
Member Author

@yiendos Would you mind giving this a go on your end too? This should solve an issue Waseem is having installing the console in a Valet environment. You can try it directly on the box with:

# Temporarily remove folioshell because it's not updated yet
composer global remove foliolabs/folioshell
# Install this branch
composer global require joomlatools/console:dev-feature/129-symfony5 
# Now upgrade symfony/console
composer global require symfony/console:^5.0
# Verify with
composer global show | grep symfony/console

Then make sure all commands still work. These changes are very minimal so no need to run through every command explicitely.

@stevenrombauts
Copy link
Member Author

@yiendos Note, if this works OK we can add this to the 1.5.9 tag along with #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants