Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension:install composer packages #14

Closed
tomjanssens opened this issue Apr 15, 2016 · 7 comments · Fixed by #76
Closed

extension:install composer packages #14

tomjanssens opened this issue Apr 15, 2016 · 7 comments · Fixed by #76
Milestone

Comments

@tomjanssens
Copy link

If a package name (vendor/package) is passed to the extension:install command, install it using Composer

@tomjanssens tomjanssens added this to the Current milestone Apr 15, 2016
yiendos added a commit that referenced this issue May 15, 2017
@yiendos
Copy link
Member

yiendos commented May 15, 2017

@stevenrombauts the above commit was started at the Timble Workshop. On the train you said there might be other relevant tickets relating to composer?

@yiendos yiendos self-assigned this May 15, 2017
@stevenrombauts
Copy link
Member

@yiendos I was referring to tickets #21 and #28. But this ticket is still unrelated to those right now: here we just want to be able to install components by package name instead of local directory.

For example: joomla extension:install joomlatools/joomla-todo should recognise the name as a Composer package (format foo/bar) and instead of calling the bootstrapper and the installer logic, it should do a composer require <package name>.

yiendos added a commit that referenced this issue May 19, 2017
- ability to install composer and J extensions sequentially
- brought in composer process to help catch composer require errors
yiendos added a commit that referenced this issue May 22, 2017
yiendos added a commit that referenced this issue May 23, 2017
- therefore going to roll back to passthru
yiendos added a commit that referenced this issue May 23, 2017
- site:create timble --symlink textman only passes in 'all'
- putting back in place original type casting
yiendos added a commit that referenced this issue May 23, 2017
@yiendos
Copy link
Member

yiendos commented May 23, 2017

Note regex used in branch

Is tested against the following:
https://regex101.com/r/fHlWZZ/1

yiendos added a commit that referenced this issue May 24, 2017
- use array_map and array_filter to generate
- use strpos to determine whether / present
@stevenrombauts
Copy link
Member

@yiendos Does this require any more work?

@yiendos
Copy link
Member

yiendos commented Nov 18, 2017

hmmm @stevenrombauts I honestly can't remember the state of this ticket. I can jump back in and refresh myself with the code

@stevenrombauts
Copy link
Member

Thanks @yiendos, nothing urgent, it looks like this code is basically finished so no reason not to include it in the upcoming 1.5 release then - unless it needs a lot more work.

yiendos added a commit that referenced this issue Nov 20, 2017
@yiendos yiendos assigned stevenrombauts and unassigned yiendos Nov 20, 2017
stevenrombauts pushed a commit that referenced this issue Nov 28, 2017
stevenrombauts pushed a commit that referenced this issue Nov 28, 2017
stevenrombauts pushed a commit that referenced this issue Nov 28, 2017
stevenrombauts pushed a commit that referenced this issue Dec 12, 2017
@stevenrombauts
Copy link
Member

Working like a charm, @yiendos. Thanks!

@stevenrombauts stevenrombauts removed their assignment Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants