Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --clone argument #36

Closed
tomjanssens opened this issue Apr 15, 2016 · 0 comments
Closed

Add --clone argument #36

tomjanssens opened this issue Apr 15, 2016 · 0 comments
Milestone
1.5.0

Comments

@tomjanssens
Copy link

tomjanssens commented Apr 15, 2016 •
edited by stevenrombauts
Loading

Instead of downloading the site from and extracting it to /var/www, make it possible to clone the repo instead.
@tomjanssens tomjanssens added this to the Backlog milestone Apr 15, 2016
@stevenrombauts stevenrombauts changed the title Add site:clone command Add --clone argument Nov 20, 2017
@stevenrombauts stevenrombauts modified the milestones: Backlog, 1.5 Nov 20, 2017
stevenrombauts pushed a commit that referenced this issue Dec 12, 2017
#36: Split _clone() method into _clone() and _archive()
51c356e
stevenrombauts pushed a commit that referenced this issue Dec 12, 2017
#36: Implement direct clone functionality
ad41c45
stevenrombauts pushed a commit that referenced this issue Dec 12, 2017
#36: Fix --clone option default value
acbf9fa 
The InputOption::VALUE_OPTIONAL option mode will always return
null if you don't set a default value, but returning any other value
makes it impossible to correctly determine whether the flag was
set or not.

Solution is to rely on $input->hasParameterOption() instead.

See: https://github.com/symfony/symfony/issues/11572\#issuecomment-197929086
@stevenrombauts stevenrombauts mentioned this issue Dec 12, 2017
Merged
@stevenrombauts stevenrombauts mentioned this issue Dec 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@stevenrombauts @tomjanssens