Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension:install bug when using discover install #61

Closed
myser90 opened this issue May 17, 2017 · 2 comments
Closed

extension:install bug when using discover install #61

myser90 opened this issue May 17, 2017 · 2 comments
Labels
Milestone

Comments

@myser90
Copy link

myser90 commented May 17, 2017

In Extension.Install.php

 $model = new \InstallerModelDiscover();
 $model->discover();

 $results = $model->getItems();

But $model->getItems() return limited result. By default only 20 extensions have been returning.

In getItems:

		try
		{
			// Load the list items and add the items to the internal cache.
			$this->cache[$store] = $this->_getList($this->_getListQuery(), $this->getStart(), $this->getState('list.limit'));
		}

As a result, if the extension is not included in the first twenty, it will be ignored.

@stevenrombauts stevenrombauts added this to the 1.5 milestone May 22, 2017
@stevenrombauts
Copy link
Member

Thanks @myser90, this should be easily solved by setting the limit state to a larger number. Pull Requests welcome! :)

@stevenrombauts
Copy link
Member

This has been solved and will be included in the upcoming 1.5 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants