-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade symfony/console #86
Comments
as a workaround so far, I use https://github.com/consolidation/cgr, otherwise I can't install due to other tools including symfony itself require ^4.0 thus end up in lot of dependency conflicts |
@stevenrombauts Is this something we can resolve with priority in a maintenance release? |
@glumanda99 You can use this branch now to install alongside packages that require the newer symfony/console: |
@johanjanssens I've updated the dependency and tested the commands, we can put this out in a maintenance release. One issue, on Vagrant box we have phing/phing installed, which also relies on older symfony/console. The auto-updater in the box will attempt to download latest joomlatools/console, but that will break. We can add a FAQ item on how to solve that (removing phing/phing is the best option here, we don't use it on JT Vagrant box at all.) Thoughts? |
If are not using phing lets remove it. Could warrant a maintenance release of the box too, or can the uninstall be handled during composer update? |
@johanjanssens Rolling out a little maintenance release for the box will be the best way forward. Adding a hook and logic to remove it is probably going to be complicated and result in one big hack. I'll prepare a maintenance release, should also fix joomlatools/joomlatools-vagrant#123 and joomlatools/joomlatools-vagrant#121 along with this Console issue. |
Note: we still require this for building packages, so we need to upgrade it on the box. Ticket has been amended. |
@stevenrombauts agreed. |
@glumanda99 This change has been included in the v1.5.1 release. |
The symfony/console package version is currently locked at 2.7.x, while 4.0 is already released. Update composer.json and the code accordingly.
The text was updated successfully, but these errors were encountered: