Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/109-restarts #110

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Merge feature/109-restarts #110

merged 1 commit into from
Jul 10, 2019

Conversation

stevenrombauts
Copy link
Member

Closes #109

@stevenrombauts stevenrombauts added this to the 1.6 milestone Jul 3, 2019
@stevenrombauts stevenrombauts requested a review from yiendos July 3, 2019 13:36
@stevenrombauts stevenrombauts self-assigned this Jul 3, 2019
Copy link
Member

@yiendos yiendos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenrombauts looking good to me, I can override a site vhost via:
joomla vhost:create textman --apache-template=/tmp/sample.conf

And then I can revert the changes by:
joomla vhost:create textman

Each time the browser picks up the changes, so we can assume the servers have been restarted. Good work

@stevenrombauts stevenrombauts merged commit 2e6f0ab into master Jul 10, 2019
@stevenrombauts stevenrombauts deleted the feature/109-restarts branch July 10, 2019 14:00
@stevenrombauts
Copy link
Member Author

@yiendos Great, thanks!

@stevenrombauts stevenrombauts removed their assignment Jul 10, 2019
@stevenrombauts stevenrombauts modified the milestones: 1.6, 1.5.4 Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only execute service restarts on box
2 participants