Enable Joomla 4 to be installed #126
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yiendos
changed the title
|
@stevenrombauts I think this should enable us to install Joomla 4 by the console. Would you mind giving this a test please? |
|
Hi guys! Keep up the good job! I can't wait to see this feature coming in jt console. Tried today and had a db error kinda know where it comes from but you are the experts. Still learning from Timblians. |
|
hey @alexandreelise thanks for testing, could you try again and post any error messages (copy/ paste/ screenshot) here? Keen to test this out on as many different systems as possible. |
|
Did a composer global update but your changes are not there yet. How to test before official release? |
|
It works as expected with Tony tweaks on m machine |
|
@alexandreelise hi thanks for this and sorry for not getting back sooner. I guess the quickest way I can think of testing this branch would have been:
|
|
hi @yiendos i was scared for nothing. it was a piece of cake. thanks for your help anyway. |
There was a problem hiding this comment.
@yiendos Had another go with this one and working like a charm on my end. Anything else needed here? If not this can be merged.
| $files[] = $path.'joomla.sql'; | ||
| $version = Util::getJoomlaVersion($this->target_dir); | ||
|
|
||
| if (version_compare($version->release, '3.9', '>')) |
There was a problem hiding this comment.
@yiendos This should be greater or equal than 4.0, because now it's also using these SQL files for 3.9.x versions, which breaks installation.
There was a problem hiding this comment.
@stevenrombauts great catch that was complete fubar... I've just run over the alpha => beta installs again today and turns out that only the beta versions have the new sql files... and no doubt in the future the dev team will roll back to the single joomla.sql file. So I've put a catch in for this as well. Let me know what you think
There was a problem hiding this comment.
@yiendos Makes sense :) I think this is ready to go then and can be merged into master. You'll also need to update the CHANGELOG though and tag a new v1.5.9 version, so Composer will pick it up.
Closes #125