Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for configuration file #132

Merged
merged 7 commits into from
Feb 10, 2021
Merged

Conversation

github-actions[bot]
Copy link

Closes #131

@ercanozkaya ercanozkaya merged commit 5b995da into master Feb 10, 2021
@ercanozkaya ercanozkaya deleted the feature/131-config-overrides branch February 10, 2021 12:44
@amazeika amazeika added this to the v1.6.0 milestone Feb 15, 2021
@yiendos
Copy link
Member

yiendos commented Feb 16, 2021

@amazeika I did by chance upgrade to 1.6.0 the other day, when it was available... it broke my console commands:

joomla site:list
PHP Fatal error:  Uncaught Error: Class 'Joomlatools\Console\Command\Configurable' not found in /home/vagrant/.composer/vendor/joomlatools/console/src/Joomlatools/Console/Command/Site/AbstractSite.php:18
Stack trace:
#0 /home/vagrant/.composer/vendor/composer/ClassLoader.php(444): include()
#1 /home/vagrant/.composer/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/home/vagrant/....')
#2 [internal function]: Composer\Autoload\ClassLoader->loadClass('Joomlatools\\Con...')
#3 /home/vagrant/.joomlatools/console/plugins/vendor/joomlatools/console-travis/Joomlatools/Console/Command/Travis.php(16): spl_autoload_call('Joomlatools\\Con...')
#4 /home/vagrant/.composer/vendor/composer/ClassLoader.php(444): include('/home/vagrant/....')
#5 /home/vagrant/.composer/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/home/vagrant/....')
#6 [internal function]: Composer\Autoload\ClassLoader->loadClass('Joomlatools\\Con...')
#7 [internal function]: spl_autoload_call('Joomlatools\\Con...')
#8 /home/vagran in /home/vagrant/.composer/vendor/joomlatools/console/src/Joomlatools/Console/Command/Site/AbstractSite.php on line 18

Steven identified the problem as being the lower case nature of the file name:
https://github.com/joomlatools/joomlatools-console/pull/132/files#diff-66a98471469035d37a9d58880482fd398c27cd6560a80a52721aca457e96cc4f

Configurable.php not configurable.php

@yiendos
Copy link
Member

yiendos commented Feb 16, 2021

@amazeika I'll give this another spin again today, excited to give it a whirl!

@amazeika
Copy link
Member

@yiendos Yes, it Ercan tagged it by mistake, now it's good. I also fixed vhost:alias which was broken. The loader issue with configurable wasn't a problem on my end for some reason ... please let me know if all is good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for default overrides config file
3 participants