Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return PHP 7.3 compatibility, replace eval() with AST #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

msaladna
Copy link
Contributor

Presently composer.lock is generated against PHP 8.0.2+, which breaks library installation against PHP 7.3/4. Reduce third-party versioning to preserve this guarantee.

@msaladna
Copy link
Contributor Author

Replaced eval() usage with nikic's AST parser. This handles Joomla 2-5 and can be easily extended without finagling with class declarations. A few other changes were implemented, annotated in the commit log.

object(Joomlatools\Console\Joomla\VersionSniffer)#271 (5) {
  ["release"]=>
  string(5) "3.6.5"
  ["major"]=>
  int(3)
  ["minor"]=>
  int(6)
  ["patch"]=>
  int(5)
  ["extra"]=>
  string(0) ""
}

object(Joomlatools\Console\Joomla\VersionSniffer)#271 (5) {
  ["release"]=>
  string(5) "5.0.0"
  ["major"]=>
  int(5)
  ["minor"]=>
  int(0)
  ["patch"]=>
  int(0)
  ["extra"]=>
  string(0) ""
}

object(Joomlatools\Console\Joomla\VersionSniffer)#271 (5) {
  ["release"]=>
  string(9) "4.3.1-rc1"
  ["major"]=>
  int(4)
  ["minor"]=>
  int(3)
  ["patch"]=>
  int(1)
  ["extra"]=>
  string(3) "rc1"
}

object(Joomlatools\Console\Joomla\VersionSniffer)#269 (5) {
  ["release"]=>
  string(6) "2.5.27"
  ["major"]=>
  int(2)
  ["minor"]=>
  int(5)
  ["patch"]=>
  int(27)
  ["extra"]=>
  string(0) ""
}

@msaladna msaladna changed the title Require Composer dependencies against PHP 7.3 to preserve commitment Return PHP 7.3 compatibility, replace eval() with AST Nov 24, 2023
plugin:list-all does not extend AbstractSite, infer $target_dir from CWD
Remove non-specific "type" property from site:list
Verify runtime  path is writeable falling back to system temp directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant