Fix autoload path for custom composer vendor-dir

[SmetDenis]

Hi,

I have to config my composer.json like that

    "config"            : {
        "bin-dir" : "../../bin",
        "vendor-dir" : "libraries",
   }

And it's located here <MY_PROJECT_ROOT>/src/cck/composer.json
My binaries here <MY_PROJECT_ROOT>/bin

And than a I tried to call joomlatools, fatal error apperied

$ ./bin/joomla

Warning: require(<MY_PROJECT_ROOT>/src/cck/libraries/joomlatools/console/bin/../../../../vendor/autoload.php): failed to open stream: No such file or directory in <MY_PROJECT_ROOT>/src/cck/libraries/joomlatools/console/bin/joomla on line 13

Fatal error: require(): Failed opening required '<MY_PROJECT_ROOT>/src/cck/libraries/joomlatools/console/bin/../../../../vendor/autoload.php' (include_path='.') in <MY_PROJECT_ROOT>/src/cck/libraries/joomlatools/console/bin/joomla on line 13

I think you should remove hardcode vendor and get location form config or accept my pull request

For example, PHPUnit works fine with my config and with default vendor-dir
https://github.com/sebastianbergmann/phpunit/blob/master/phpunit#L25

Now I just create symlink vendor -> libraries

Thanks and best regards, Denis.

[SmetDenis]

Hi

Well what do you think?

[johanjanssens]

Hello Dennis, at first sight this is looking good. The developer in charge of the console is on holiday at the moment, he will review your PR on his return and get back to you. Thanks for this! Very much appreciated.

[stevenrombauts]

@SmetDenis Thanks for this, this will do just fine. Tested and merged.

The current solution however still hardcodes every path, there are just more of them now. Not sure yet how we could improve this. I'll create a separate ticket in backlog to see if we can figure something out.