Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Http Cache Proxy #304

Closed
johanjanssens opened this issue Apr 2, 2020 · 0 comments
Closed

Async Http Cache Proxy #304

johanjanssens opened this issue Apr 2, 2020 · 0 comments
Assignees
@johanjanssens
Labels
feature
Milestone
v0.18.0

Comments

@johanjanssens
Copy link
Member

Refactor the http cache proxy to work async. Using an async proxy ensures that each request will be equally fast as the cache will be validated or regenerated in the background.
@johanjanssens johanjanssens added this to the 0.18.0 milestone Apr 2, 2020
@johanjanssens johanjanssens self-assigned this Apr 2, 2020
johanjanssens added a commit that referenced this issue Apr 2, 2020
@johanjanssens
#304 - Refactor http cache proxy
00739fc 
- Turn off output_buffering and output_compression
- Pass in a callback to execute the application
- Do not handle cache expiration
- Only validate cache based on etag, remove support for last-modified
- Use  fastcgi_finish_request(); to flush all response data to the client
- Remove use of  PROXY-REFRESHED and PROXY-HIT status codes
johanjanssens added a commit that referenced this issue Apr 2, 2020
@johanjanssens
#304 - Refactor http cache behavior
0ba8093 
- Store refreshed cache and calculate Age if needed
- Do not set Last-Modified header only use Etag validation
- Implement cache as an action to allow event listeners to intercept it
johanjanssens added a commit that referenced this issue Apr 2, 2020
@johanjanssens
#304 - Do not send the response if headers are already send
088f23f 
This allows the code to work with the async http cache proxy. Without it
a exception will be thrown that headers have already been send.
johanjanssens added a commit that referenced this issue Apr 6, 2020
@johanjanssens
#304 - Refactor cacheable behavior
56212d0 
Rename isCached() to loadCache() and return the cache as an array
johanjanssens added a commit that referenced this issue Apr 6, 2020
@johanjanssens
#304 - Do not prefetch the same page
feb337a
johanjanssens added a commit that referenced this issue Apr 7, 2020
@johanjanssens
#304 - Clear stat cache for the response to ensure the check for is_f…
38b96a1 
…ile()

returns correctly.
johanjanssens added a commit that referenced this issue May 9, 2020
@johanjanssens
#304 - Generate a stale warning following rfc7234 requirements
2235c82 
- Generate a Warning: 110 Joomlatools/Pages "Response is Stale" header if the response is stale.
- Calcule the correct Age
- Force set the Cache-Status to HIT
johanjanssens added a commit that referenced this issue May 9, 2020
@johanjanssens
#304 - Update Warning
9600cc3 
Include Joomlatools/Pages agent string following https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Warning
johanjanssens added a commit that referenced this issue May 9, 2020
@johanjanssens
#304 - Terminate response if headers have already been send
5a4bd0b
johanjanssens added a commit that referenced this issue May 10, 2020
@johanjanssens
#304 - Handling Validation Request correctly
535c0fd 
Generating a 304 response MUST generate any of the following header
fields that would have been sentin a 200 (OK) response to the same
request: Cache-Control, Content-Location, Date, ETag and Vary

Ensure the Date header is refreshed upon validation of a request
johanjanssens added a commit that referenced this issue May 11, 2020
@johanjanssens
#304 - Divide the max_age in half, as it takes 2 request to refresh it
c6988bb
johanjanssens added a commit that referenced this issue Sep 9, 2020
@johanjanssens
#304 - Remove Warning header is deprecated
ba6217f 
See: httpwg/http-core#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanjanssens johanjanssens

Labels
feature
Projects
None yet
Milestone
v0.18.0
Development

No branches or pull requests
1 participant
@johanjanssens