Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Fix the styles of media and finder component in the admin #360

Open
allanpilarca opened this issue May 8, 2018 · 10 comments
Open

Fix the styles of media and finder component in the admin #360

allanpilarca opened this issue May 8, 2018 · 10 comments
Assignees
Labels
Milestone

Comments

@allanpilarca
Copy link
Contributor

Add template override for:

  • platform-media
  • platform-finder
  • image selector for intro/full image in article page
@allanpilarca allanpilarca added this to the 2.0 milestone May 8, 2018
@raeldc raeldc changed the title Fix the styles of media and finder component in the backend Fix the styles of media and finder component in the admin May 15, 2018
robinpoort added a commit that referenced this issue May 30, 2018
robinpoort added a commit that referenced this issue May 30, 2018
robinpoort added a commit that referenced this issue May 31, 2018
@robinpoort
Copy link
Contributor

@allanpilarca could you check search and media?

There's also some stuff that needs to be done which I can't figure out how to exactly:

  1. When in media (administrator/index.php?option=com_media) you can use the tree to navigate and items will get highlighted, however navigating on the right side will not highlight the proper tree item on the left. Is that something we could fix you think?
  2. There's some settings in the image modal view (web/administrator/templates/elysio/html/com_media/images/default.php) which I put inside <?php if(!==2): ?> to hide it. Is this something we need? If so I need to style it, if not, let's remove it.

Some extensive testing might be wise ;)

@allanpilarca
Copy link
Contributor Author

hi @robinpoort

  1. I made a fix to change the selected item from the tree when you selected a directory in the media box

  2. Yes we need that, you need to enable the image editor-xtd plugin for you to see it. In the content edit page click the image button.

screen shot 2018-06-01 at 2 35 09 pm

Here are some of the issues i encountered while testing:

com:media

  1. The tree structure is not correctly displayed, only the first child content is displayed under its parent
    screen shot 2018-05-31 at 5 37 22 pm

  2. Some images thumbnails are too big that it hides the filename and delete button
    screen shot 2018-05-31 at 5 54 09 pm

  3. The breadcrumb does not displayed the current path of the file. It keeps displaying images/ even you are in subdirectory
    screen shot 2018-06-01 at 12 01 52 pm

com:finder

  1. When clicking the statistics button in Index Content page a modal a displayed but there is no content in it but if you check it the markup content is there.
    screen shot 2018-06-01 at 2 05 26 pm

  2. No content/result message is displayed even there are contents
    screen shot 2018-06-01 at 2 01 12 pm

robinpoort added a commit that referenced this issue Jun 1, 2018
@robinpoort
Copy link
Contributor

@allanpilarca

  1. Awesome!
  2. Pushed a fix so this is properly styled as well

com:media

  1. As discussed on Slack you are going to refactor the tree
  2. Fixed
  3. Could you take a look at that as well?

com:finder

Going to take a look at both issues

robinpoort added a commit that referenced this issue Jun 1, 2018
@robinpoort
Copy link
Contributor

@allanpilarca com:finder fixes pushed

allanpilarca added a commit that referenced this issue Jun 1, 2018
@allanpilarca
Copy link
Contributor Author

@robinpoort i applied the fix for media tree, could you please check it?

@robinpoort
Copy link
Contributor

@allanpilarca Looking good to me! Great work!

allanpilarca added a commit that referenced this issue Jun 4, 2018
@allanpilarca
Copy link
Contributor Author

@robinpoort

Done fixing the breadcrumb. Found two small styling issues:

  1. When selecting intro/full article image the image is bigger on its wrapper

screen shot 2018-06-06 at 10 10 29 am

  1. In category options tab, the image selector is not styled
    screen shot 2018-06-06 at 10 22 05 am

allanpilarca added a commit that referenced this issue Jun 7, 2018
This hidden input field is not needed, it just upload the image in the root media directory
@allanpilarca
Copy link
Contributor Author

@robinpoort

Made a fix when uploading a file it's not uploaded in the selected directory.

Another issue i found is the folder selectbox doesn't change when you click a subfolder.

screen shot 2018-06-07 at 11 27 59 am

@robinpoort
Copy link
Contributor

@allanpilarca Should be fixed, could you check?

@allanpilarca
Copy link
Contributor Author

@robinpoort tested and its working perfectly!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants