This repository has been archived by the owner on Feb 4, 2021. It is now read-only.
If display_errors is FALSE exception messages are still printed to the screen #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure the exception code is a valid HTTP status code, if not revert to '500'. - If display_errors is off, use the formal HTTP status message instead of the custom exception message to prevent system information leaking to the output.
- Add 'code' parameter. Default to the exception code. - Add 'message' parameter. Default to the exception message. - Ensure the exception code is a valid HTTP status code, if not revert to '500'. - If display_errors is off, use the formal HTTP status message instead of the custom exception message to prevent system information leaking to the output.
…f display_errors is TRUE.
| } | ||
|
|
||
| // Exit immediatly if we are in a CLI environment | ||
| if (PHP_SAPI == 'cli') |
There was a problem hiding this comment.
before the condition was !$document, I'd keep it in addition to PHP_SAPI check. Otherwise this might break in json, xml etc where JDocument returns null.
There was a problem hiding this comment.
@ercanozkaya Agreed.
johanjanssens
added a commit
that referenced
this pull request
Aug 31, 2015
If display_errors is FALSE exception messages are still printed to the screen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #163