Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3 segment storage #75

Merged
merged 5 commits into from
Jun 15, 2022
Merged

feat: s3 segment storage #75

merged 5 commits into from
Jun 15, 2022

Conversation

loydbanks
Copy link

@loydbanks loydbanks commented May 3, 2022

Fixes #23

@loydbanks loydbanks marked this pull request as ready for review May 3, 2022 17:34
Copy link
Owner

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload mechanism must happen every time a new file is generated by ffmpeg, you should trigger an upload once the segment list file receives a new entry.

Not totally sure how to do this cleanly, but maybe writing to stdout and reading from there line by line might be a good idea.

@loydbanks loydbanks force-pushed the s3_media_upload branch 6 times, most recently from 2fc8b5d to f35ef9e Compare June 7, 2022 18:32
@paddatrapper
Copy link

Please document how to use this

@loydbanks loydbanks force-pushed the s3_media_upload branch 3 times, most recently from 9f4a2b9 to aeec124 Compare June 14, 2022 09:48
@jooola jooola changed the title S3 media upload feat: s3 segment storage Jun 14, 2022
@jooola
Copy link
Owner

jooola commented Jun 14, 2022

Thanks for the work.

I'll take care off rebasing onto main, and integrating everything with the latest changes.

@jooola jooola force-pushed the s3_media_upload branch 2 times, most recently from da10423 to 92d73c4 Compare June 15, 2022 10:22
jooola and others added 4 commits June 15, 2022 13:37
- docs: add .env usage

Co-authored-by: loydbanks <lonwabo@bitcast.co.za>
Co-authored-by: loydbanks <lonwabo@bitcast.co.za>
@jooola jooola force-pushed the s3_media_upload branch from c3cf272 to 46ed55a Compare June 15, 2022 11:39
@jooola jooola merged commit 85f5fca into jooola:main Jun 15, 2022
@paddatrapper
Copy link

Thanks!

@jooola
Copy link
Owner

jooola commented Jun 15, 2022

I'll release an alpha version, it would be awesome if you can test it, as I don't have any s3 storage to do so.

@paddatrapper
Copy link

Sure, will do

@jooola
Copy link
Owner

jooola commented Jun 15, 2022

The new version has been published, please read the change log, there is a breaking change.

@paddatrapper
Copy link

paddatrapper commented Jun 15, 2022

It works as expected. The only thing is that the docker image does not support it because extra dependencies are not installed when installing the wheel built by poetry build - python-poetry/poetry#2567. I opened #88 about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow archive to S3
3 participants