-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: s3 segment storage #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upload mechanism must happen every time a new file is generated by ffmpeg, you should trigger an upload once the segment list file receives a new entry.
Not totally sure how to do this cleanly, but maybe writing to stdout and reading from there line by line might be a good idea.
2fc8b5d
to
f35ef9e
Compare
Please document how to use this |
9f4a2b9
to
aeec124
Compare
aeec124
to
f9c74ee
Compare
f9c74ee
to
e3ffe04
Compare
Thanks for the work. I'll take care off rebasing onto main, and integrating everything with the latest changes. |
da10423
to
92d73c4
Compare
- docs: add .env usage Co-authored-by: loydbanks <lonwabo@bitcast.co.za>
Co-authored-by: loydbanks <lonwabo@bitcast.co.za>
Thanks! |
I'll release an alpha version, it would be awesome if you can test it, as I don't have any s3 storage to do so. |
Sure, will do |
The new version has been published, please read the change log, there is a breaking change. |
It works as expected. The only thing is that the docker image does not support it because extra dependencies are not installed when installing the wheel built by |
Fixes #23