Support mealplan notes #171
Merged
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 97.20% 96.80% -0.40%
==========================================
Files 4 4
Lines 179 188 +9
Branches 21 21
==========================================
+ Hits 174 182 +8
- Misses 3 4 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
joostlek
commented
Jun 29, 2024
|
|
||
| def serialize(self, value: str | None) -> str | None: | ||
| """Serialize optional string.""" | ||
| return value |
There was a problem hiding this comment.
This is not used internally and would only be used by external usage, looks trivial so no unit tests here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for fetching the fields of mealplans that only have a note and no recipe attached