Fix cannot connect #277
Merged
Fix cannot connect #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 99.07% 99.08%
=======================================
Files 4 4
Lines 324 327 +3
Branches 36 37 +1
=======================================
+ Hits 321 324 +3
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
joostlek
reviewed
Oct 3, 2024
| async def test_client_connection_error() -> None: | ||
| """Test client connection error from mealie.""" | ||
|
|
||
| async with MealieClient(api_host="https://bad-url") as mealie_client: |
There was a problem hiding this comment.
Ah! I also made a fix on a local branch but couldn't figure out yet how its testable
There was a problem hiding this comment.
I struggled with this as well, but I'm learning 😄
joostlek
approved these changes
Oct 3, 2024
joostlek
added
the
bugfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Throw proper mealie connection error when unable to connect to client to allow retry.
Related Issues
home-assistant/core#126906