fix: remove redundant async

jooy2 · May 6, 2024 · ed461e7 · ed461e7
1 parent a202bf0
commit ed461e7
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 21 deletions.
diff --git a/src/renderer/components/dialogs/ModalLocalStorageView.tsx b/src/renderer/components/dialogs/ModalLocalStorageView.tsx
@@ -29,7 +29,7 @@ const ModalLocalStorageView = () => {
     [stateAppScreen.appConfigLanguage],
   );
 
-  const handleDialogClose = async () => {
+  const handleDialogClose = () => {
     setData(JSON.stringify(localStorage));
     setError(false);
     dispatch(setConfig({ dialogLocalStorageViewOpen: false }));
@@ -54,7 +54,7 @@ const ModalLocalStorageView = () => {
           localStorage.setItem(key, value.toString());
         }
       });
-      await handleDialogClose();
+      handleDialogClose();
     } catch {
       setError(true);
     }
@@ -69,7 +69,7 @@ const ModalLocalStorageView = () => {
     localStorage.setItem('i18nextLng', i18LngValue);
     setData(JSON.stringify(localStorage));
     handleOpenConfirm(false);
-    await handleDialogClose();
+    handleDialogClose();
   };
 
   return (

diff --git a/src/renderer/components/dialogs/ModalMetadata.tsx b/src/renderer/components/dialogs/ModalMetadata.tsx
@@ -22,7 +22,7 @@ const ModalMetadata = () => {
   const stateAppScreen = useSelector((state: RootState) => state.appScreen);
   const dispatch = useDispatch();
 
-  const handleDialogClose = async () => {
+  const handleDialogClose = () => {
     dispatch(setConfig({ dialogMetadataOpen: false }));
   };
 

diff --git a/src/renderer/components/layouts/Header.tsx b/src/renderer/components/layouts/Header.tsx
@@ -42,11 +42,11 @@ const Header = ({ title, withBackButton, withRefresh = false }) => {
     }
   };
 
-  const handleOpenMetadata = async () => {
+  const handleOpenMetadata = () => {
     dispatch(setConfig({ dialogMetadataOpen: true }));
   };
 
-  const handleFlashEmulatePlayerVersionChange = async (event) => {
+  const handleFlashEmulatePlayerVersionChange = (event) => {
     dispatch(setConfig({ appConfigEmulatePlayerVersion: event.target.value }));
   };
 

diff --git a/src/renderer/components/views/FlashPlayer.tsx b/src/renderer/components/views/FlashPlayer.tsx
@@ -41,7 +41,7 @@ const FlashPlayer = ({ url = '', autoplay = true, filePath = '', header = true }
     }
   };
 
-  const handleMute = async () => {
+  const handleMute = () => {
     if (stateAppScreen.flashVolume === 0) {
       rufflePlayer.volume = 1;
       dispatch(setConfig({ flashVolume: 100 }));
@@ -51,7 +51,7 @@ const FlashPlayer = ({ url = '', autoplay = true, filePath = '', header = true }
     }
   };
 
-  const handleVolumeSliderChange = async (event, newValue) => {
+  const handleVolumeSliderChange = (event, newValue) => {
     rufflePlayer.volume = newValue / 100;
     dispatch(setConfig({ flashVolume: newValue }));
   };
@@ -125,7 +125,7 @@ const FlashPlayer = ({ url = '', autoplay = true, filePath = '', header = true }
     }
 
     rufflePlayer.id = 'player';
-    rufflePlayer.addEventListener('loadedmetadata', async () => {
+    rufflePlayer.addEventListener('loadedmetadata', () => {
       const metaData = rufflePlayer?.metadata;
       dispatch(
         setConfig({

diff --git a/src/renderer/screens/Explorer.tsx b/src/renderer/screens/Explorer.tsx
@@ -35,7 +35,7 @@ const Explorer = () => {
   const [loading, setLoading] = useState(false);
   const [flashContentError, setFlashContentError] = useState(false);
   const [errorMessage, setErrorMessage] = useState('');
-  const runFlash = async (fileName, filePath) => {
+  const runFlash = (fileName: string, filePath: string) => {
     setLoading(true);
     dispatch(
       setConfig({
@@ -66,7 +66,9 @@ const Explorer = () => {
       setErrorMessage(t('notice:wrong-file-type') as SetStateAction<string>);
       return false;
     }
-    await runFlash(file?.name, filePath);
+
+    runFlash(file?.name, filePath);
+
     return true;
   }, []);
   const { getRootProps, getInputProps } = useDropzone({
@@ -87,7 +89,7 @@ const Explorer = () => {
     });
   };
 
-  const handleRemoveRecentFiles = async () => {
+  const handleRemoveRecentFiles = () => {
     window.mainApi.send('removeAllRecentFile');
     dispatch(
       setConfig({
@@ -107,7 +109,7 @@ const Explorer = () => {
 
     window.mainApi.receive('receiveFileExist', async (event, argument) => {
       if (argument.exist) {
-        await runFlash(argument.name, argument.path);
+        runFlash(argument.name, argument.path);
       } else {
         window.mainApi.send('removeRecentFile', {
           path: argument.path,

diff --git a/src/renderer/screens/Main.tsx b/src/renderer/screens/Main.tsx
@@ -24,7 +24,7 @@ const Main = () => {
 
   const handleVersionCheck = async () => true; // TODO version check
 
-  const runFromExplorer = async (filePath: string): Promise<void> => {
+  const runFromExplorer = (filePath: string): void => {
     dispatch(
       setConfig({
         flashFileName: filePath.split('\\').pop(),
@@ -91,14 +91,14 @@ const Main = () => {
           await i18n.changeLanguage(configs.language);
         }
 
-        window.mainApi.receive('receiveOpenFile', async (openFileEvent, receivePath) => {
-          await runFromExplorer(receivePath);
+        window.mainApi.receive('receiveOpenFile', (openFileEvent, receivePath) => {
+          runFromExplorer(receivePath);
         });
 
         setLoadMsg(3);
 
         if (filePath) {
-          await runFromExplorer(filePath);
+          runFromExplorer(filePath);
         } else {
           navigate('/explorer');
         }

diff --git a/src/renderer/screens/Player.tsx b/src/renderer/screens/Player.tsx
@@ -14,7 +14,7 @@ const Player = () => {
   const navigate = useNavigate();
 
   useEffect(() => {
-    window.mainApi.receive('receiveResumeToExplorer', async () => {
+    window.mainApi.receive('receiveResumeToExplorer', () => {
       dispatch(
         setConfig({
           flashFileName: '',

diff --git a/src/renderer/screens/Settings.tsx b/src/renderer/screens/Settings.tsx
@@ -49,7 +49,7 @@ const Settings = () => {
   );
   const prefersDarkMode = useMediaQuery('(prefers-color-scheme: dark)');
 
-  const handleRadioChange = async (event): Promise<void> => {
+  const handleRadioChange = (event): void => {
     const { value } = event.target;
     switch (event.target.name) {
       case 'themeCheck':
@@ -77,8 +77,9 @@ const Settings = () => {
     }
   };
 
-  const handleCheckboxChange = async (event): Promise<void> => {
+  const handleCheckboxChange = (event): void => {
     const value = event.target.checked;
+
     switch (event.target.name) {
       case 'hideHeaderChecked':
         setHideHeaderChecked(value);
@@ -139,7 +140,7 @@ const Settings = () => {
     window.mainApi.send('resetAppConfig');
   };
 
-  const handleOpenLocalStorageViewModal = async (): Promise<void> => {
+  const handleOpenLocalStorageViewModal = (): void => {
     dispatch(setConfig({ dialogLocalStorageViewOpen: true }));
   };