Skip to content

Commit

Permalink
fix: avoid downloading Ensembl ftp file in unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
jorainer committed Sep 21, 2023
1 parent 45a79a4 commit c7713b8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: ensembldb
Type: Package
Title: Utilities to create and use Ensembl-based annotation databases
Version: 2.24.0
Version: 2.24.1
Authors@R: c(person(given = "Johannes", family = "Rainer",
email = "johannes.rainer@eurac.edu",
role = c("aut", "cre"),
Expand Down
4 changes: 4 additions & 0 deletions inst/NEWS
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Changes in version 2.24.1

- Avoid reading ftp file from Ensembl in unit test.

Changes in version 2.23.2

- Fix SQLite database names to include also the subspecies.
Expand Down
8 changes: 0 additions & 8 deletions tests/testthat/test_functions-create-EnsDb.R
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,4 @@ test_that(".read_lines_compressed works", {

res_2 <- .read_lines_compressed(fl, n = 10)
expect_equal(res_2[1L], "#!genome-build ASM96941v1")

fl <- paste0(
"ftp://ftp.ensembl.org/pub/release-102/gtf/",
"homo_sapiens/Homo_sapiens.GRCh38.102.gtf.gz"
)
expect_warning(res <- readLines(fl, n = 2))
res_2 <- .read_lines_compressed(fl, n = 2)
expect_equal(res_2[1L], "#!genome-build GRCh38.p13")
})

0 comments on commit c7713b8

Please sign in to comment.