Fix: remove unneccesary scientific symbol setters

jordanbrauer · Nov 14, 2017 · 6247a6e · 6247a6e
1 parent 9fdec81
commit 6247a6e
Show file tree

Hide file tree

Showing 13 changed files with 3 additions and 25 deletions.
diff --git a/src/UnitConverter/Unit/Area/Acre.php b/src/UnitConverter/Unit/Area/Acre.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("acre")
 
-            ->setScientificSymbol("acre")
-
             ->setUnits(4046.86)
             ;
     }

diff --git a/src/UnitConverter/Unit/Area/Hectare.php b/src/UnitConverter/Unit/Area/Hectare.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("ha")
 
-            ->setScientificSymbol("ha")
-
             ->setUnits(10000)
             ;
     }

diff --git a/src/UnitConverter/Unit/Energy/Calorie.php b/src/UnitConverter/Unit/Energy/Calorie.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("cal")
 
-            ->setScientificSymbol("cal")
-
             ->setUnits(4184)
             ;
     }

diff --git a/src/UnitConverter/Unit/Energy/Joule.php b/src/UnitConverter/Unit/Energy/Joule.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("J")
 
-            ->setScientificSymbol("J")
-
             ->setUnits(1)
             ;
     }

diff --git a/src/UnitConverter/Unit/Energy/Kilojoule.php b/src/UnitConverter/Unit/Energy/Kilojoule.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("kJ")
 
-            ->setScientificSymbol("kJ")
-
             ->setUnits(1000)
             ;
     }

diff --git a/src/UnitConverter/Unit/Energy/Megaelectronvolt.php b/src/UnitConverter/Unit/Energy/Megaelectronvolt.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("MeV")
 
-            ->setScientificSymbol("MeV")
-
             ->setUnits(1.60218e-13)
             ;
     }

diff --git a/src/UnitConverter/Unit/Energy/Megajoule.php b/src/UnitConverter/Unit/Energy/Megajoule.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("MJ")
 
-            ->setScientificSymbol("MJ")
-
             ->setUnits(1000000)
             ;
     }

diff --git a/src/UnitConverter/Unit/Energy/MegawattHour.php b/src/UnitConverter/Unit/Energy/MegawattHour.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("MWh")
 
-            ->setScientificSymbol("MWh")
-
             ->setUnits(3600005446.8)
             ;
     }

diff --git a/src/UnitConverter/Unit/Length/Micrometre.php b/src/UnitConverter/Unit/Length/Micrometre.php
@@ -28,7 +28,9 @@ protected function configure (): void
         $this
             ->setName("micrometre")
 
-            ->setSymbol("µm")
+            ->setSymbol("um")
+
+            ->setScientificSymbol("µm")
 
             # 1.0E-6
             ->setUnits(0.000001)

diff --git a/src/UnitConverter/Unit/Volume/Gallon.php b/src/UnitConverter/Unit/Volume/Gallon.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("gal")
 
-            ->setScientificSymbol("gal")
-
             ->setUnits(3.78541)
             ;
     }

diff --git a/src/UnitConverter/Unit/Volume/Litre.php b/src/UnitConverter/Unit/Volume/Litre.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("L")
 
-            ->setScientificSymbol("L")
-
             ->setUnits(1)
             ;
     }

diff --git a/src/UnitConverter/Unit/Volume/Millilitre.php b/src/UnitConverter/Unit/Volume/Millilitre.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("mL")
 
-            ->setScientificSymbol("mL")
-
             ->setUnits(0.001)
             ;
     }

diff --git a/src/UnitConverter/Unit/Volume/Pint.php b/src/UnitConverter/Unit/Volume/Pint.php
@@ -30,8 +30,6 @@ protected function configure (): void
 
             ->setSymbol("pt")
 
-            ->setScientificSymbol("liq pt")
-
             ->setUnits(0.473176)
             ;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,8 +30,6 @@ protected function configure (): void @@
                 ->setSymbol("acre")
-                ->setScientificSymbol("acre")
                 ->setUnits(4046.86)
                 ;
         }
@@ Expand Down @@