Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Include Byte Unit Class to measure.php #176

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

Fakhruu
Copy link
Contributor

@Fakhruu Fakhruu commented Jun 14, 2021

Types of changes

What types of changes does your code introduce? Check/place an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Description

(Describe your changes in detail)

Motivation and Context

(Why is this change required? What problem does it solve?)
(If it fixes an open issue, please link to the issue here.)

How Has This Been Tested?

(Please describe in detail how you tested your changes.)
(Include details of your testing environment, and the tests you ran to)
(see how your change affects other areas of the code, etc.)

Screenshots:

(if appropriate)

Copy link
Owner

@jordanbrauer jordanbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am so sorry for the delay, @Fakhruu – I did not see this PR !

@jordanbrauer jordanbrauer merged commit 663fd19 into jordanbrauer:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants