wip: add pgvector implementation

.bazelrc

@@ -83,7 +83,7 @@ build:crosslinuxfips '--workspace_status_command=./build/bazelutil/stamp.sh x86_
 build:crosslinuxfips --config=crosslinuxfipsbase
 build:crosslinuxfipsbase --platforms=//build/toolchains:cross_linux
 build:crosslinuxfipsbase --config=cross
-build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.21.5fips
+build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.22.3fips
 build:crosswindows '--workspace_status_command=./build/bazelutil/stamp.sh x86_64-w64-mingw32'
 build:crosswindows --config=crosswindowsbase
 build:crosswindowsbase --platforms=//build/toolchains:cross_windows
@@ -113,12 +113,6 @@ build:macos --host_action_env=PATH=/opt/homebrew/bin:/opt/local/bin:/usr/local/b
 build:macos --linkopt="-Xlinker"
 build:macos --linkopt="-no_warn_duplicate_libraries"
 
-# --config=simplestamp configures the build to stamp the build with inferred
-# information about the configuration.
-# All `dev` builds will use this configuration; all `cross` builds will use a
-# more precise --workspace_status_command option.
-build:simplestamp --stamp --workspace_status_command=./build/bazelutil/stamp.sh
-
 build:engflowbase --define=EXECUTOR=remote
 build:engflowbase --disk_cache=
 build:engflowbase --experimental_inmemory_dotd_files

.github/CODEOWNERS

@@ -9,6 +9,8 @@
 #   maintaining team ownership) prefixing the line with `#!`.
 #   (This will hide the line from GitHub, but our internal tooling continues to
 #   parse it).
+#   Note that it is customary also to use a team name with `-noreview` suffix in
+#   the lines that start with `#!` (the suffix is trimmed in codeowners package).
 # - there is a special team @cockroachdb/unowned (only to be used with #! prefix as
 #   to not confuse Github) for the rare situations in which a file has no canonical owner.
 #   Please use this sparingly.
@@ -115,6 +117,9 @@
 /pkg/sql/zone*.go            @cockroachdb/sql-foundations
 /pkg/cmd/sql-bootstrap-data/ @cockroachdb/sql-foundations
 
+#!/pkg/sql/logictest/tests/cockroach-go-testserver-*/*.go @cockroachdb/sql-foundations-noreview
+#!/pkg/sql/logictest/tests/local-mixed-*/*.go             @cockroachdb/sql-foundations-noreview
+
 # Beware to not assign the CLI package directory to a single team, at
 # least until we heavily refactor the package to extract team-specific
 # functionality into sub-packages assigned to their respective teams.
@@ -434,6 +439,7 @@
 /pkg/cmd/generate-staticcheck/ @cockroachdb/dev-inf
 /pkg/cmd/generate-cgo/       @cockroachdb/dev-inf
 /pkg/cmd/geoviz/             @cockroachdb/spatial
+/pkg/cmd/github-action-poller/            @cockroachdb/dev-inf
 /pkg/cmd/github-post/        @cockroachdb/test-eng
 /pkg/cmd/github-pull-request-make/ @cockroachdb/dev-inf
 /pkg/cmd/gossipsim/          @cockroachdb/kv-prs

.github/bors.toml

@@ -3,7 +3,6 @@
 # List of commit statuses that must pass on the merge commit before it is
 # pushed to master.
 status = [
-       "Bazel Essential CI (Cockroach)",
        "acceptance",
        "check_generated_code",
        "docker_image_amd64",
@@ -16,6 +15,7 @@ status = [
        "local_roachtest_fips",
        "macos_amd64_build",
        "macos_arm64_build",
+       "unit_tests",
        "windows_build",
 ]
 

.github/workflows/crdb-api-client-npm-publish.yml

@@ -0,0 +1,135 @@
+# This workflow establishes two-step process of building and publishing `crdb-api-client` NPM package
+# when the produced outputs are changed comparing to last published version.
+# 1st step (first CI run) checks that built files contain changes comparing to previous version and
+# if NPM package version incremented:
+# - if yes, it publishes to NPM registry
+# - if no, new PR created (with incremented version in package.json file) which should be merged and
+# then second step is executed (runs workflow again) and publishes package.
+name: Publish crdb-api-client package to NPM registry
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - master
+    paths:
+      - 'pkg/ui/workspaces/crdb-api-client'
+      - 'pkg/**/*.proto'
+
+jobs:
+  publish_crdb_api_client:
+    if: github.repository == 'cockroachdb/cockroach'
+    environment: ${{ github.ref_name == 'master' && 'master' || null }}
+    runs-on: ubuntu-latest
+    env:
+      GH_TOKEN: ${{ github.token }}
+
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        submodules: true
+
+    - name: Bazel Cache
+      uses: actions/cache@v3
+      with:
+        path: ~/.cache/bazel
+        key: ${{ runner.os }}-bazel-cache
+
+    - uses: pnpm/action-setup@v2
+      with:
+        version: "8.6.10"
+
+    - name: Setup NodeJS
+      uses: actions/setup-node@v3
+      with:
+        node-version: 16
+        registry-url: 'https://registry.npmjs.org'
+        always-auth: true
+        cache: 'pnpm'
+        cache-dependency-path: "${{ github.workspace }}/pkg/ui/pnpm-lock.yaml"
+      env:
+        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+
+    - name: Build crdb-api-client package
+      id: bazel-build
+      run: |
+        pnpm --dir pkg/ui install
+        bazel build //pkg/ui/workspaces/crdb-api-client:crdb-api-client
+        PACKAGE_PATH=$(bazel info execution_root)/$(bazel cquery //pkg/ui/workspaces/crdb-api-client:crdb-api-client --output=files)
+        echo "package_path=$PACKAGE_PATH" >> $GITHUB_OUTPUT
+
+    - name: Check for changes
+      id: check-changes
+      working-directory: ${{ steps.bazel-build.outputs.package_path }}
+      shell: bash
+      run: |
+        if [[ $(npm diff) ]]; then
+          echo "modified=true" >> $GITHUB_OUTPUT
+        else
+          echo "modified=false" >> $GITHUB_OUTPUT
+        fi
+        PUBLISHED_VERSION=$(npm view @cockroachlabs/crdb-api-client version);
+        PACKAGE_VERSION=$(cat ./package.json | jq -r ".version");
+        echo "package_version=$PACKAGE_VERSION" >> $GITHUB_OUTPUT;
+        if [[ $PUBLISHED_VERSION == $PACKAGE_VERSION ]]; then
+          echo "same_version=true" >> $GITHUB_OUTPUT
+        else
+          echo "same_version=false" >> $GITHUB_OUTPUT
+        fi
+        # Check if PR to increment package version already exists. 
+        prs=$(gh pr list \
+          --repo "${{ github.repository }}" \
+          --head 'crdb-api-client-increment-version' \
+          --base 'master' \
+          --author 'cockroach-teamcity' \
+          --json title \
+          --jq 'length')
+        if ((prs > 0)); then
+          echo "has_pr=true" >> "$GITHUB_OUTPUT"
+        else
+          echo "has_pr=false" >> "$GITHUB_OUTPUT"
+        fi
+
+    - name: Increment version
+      if: |
+        steps.check-changes.outputs.modified == 'true' && \
+          steps.check-changes.outputs.same_version == 'true' && \
+          steps.check-changes.outputs.has_pr == 'false'
+      working-directory: pkg/ui/workspaces/crdb-api-client
+      run: npm version patch
+
+    - name: Create PR to increment package version
+      if: |
+        steps.check-changes.outputs.modified == 'true' && \
+          steps.check-changes.outputs.same_version == 'true' && \
+          steps.check-changes.outputs.has_pr == 'false'
+      uses: peter-evans/create-pull-request@v5
+      with:
+        base: master
+        token: ${{ secrets.GH_TOKEN_PR }}
+        push-to-fork: "cockroach-teamcity/cockroach"
+        add-paths: pkg/ui/workspaces/crdb-api-client/package.json
+        branch: "crdb-api-client-increment-version"
+        title: "ui: Increment @cockroachlabs/crdb-api-client version"
+        author: "CRL Release bot <teamcity@cockroachlabs.com>"
+        reviewers: koorosh
+        body: |
+          Update pkg/ui/workspaces/crdb-api-client/package.json file with incremented patch version.
+
+          Epic: None
+          Release note: None
+          Release justification: non-production code changes
+        commit-message: |
+          ui: Increment crdb-api-client version to ${{ steps.check-changes.outputs.package_version }}
+
+          Update pkg/ui/workspaces/crdb-api-client/package.json 
+          file with incremented patch version.
+
+          Epic: None
+          Release note: None
+          Release justification: non-production code changes
+        delete-branch: true
+
+    - name: Publish package
+      if: steps.check-changes.outputs.modified == 'true' && steps.check-changes.outputs.same_version == 'false'
+      working-directory: pkg/ui/workspaces/crdb-api-client
+      run: npm publish --access public --tag latest --ignore-scripts

.github/workflows/github-actions-essential-ci.yml

@@ -1,44 +1,52 @@
 name: GitHub Actions Essential CI
 on:
   pull_request:
-    types: [ opened, reopened, synchronize ]
+    types: [opened, reopened, synchronize]
     branches:
-      - 'master'
-      - 'release-*'
-      - '!release-1.0*'
-      - '!release-1.1*'
-      - '!release-2.0*'
-      - '!release-2.1*'
-      - '!release-19.1*'
-      - '!release-19.2*'
-      - '!release-20.1*'
-      - '!release-20.2*'
-      - '!release-21.1*'
-      - '!release-21.2*'
-      - '!release-22.1*'
-      - '!release-22.2*'
-      - '!release-23.1*'
-      - '!release-23.2*'
+      - "master"
+      - "release-*"
+      - "staging-*"
+      - "!release-1.0*"
+      - "!release-1.1*"
+      - "!release-2.0*"
+      - "!release-2.1*"
+      - "!release-19.1*"
+      - "!release-19.2*"
+      - "!release-20.1*"
+      - "!release-20.2*"
+      - "!release-21.1*"
+      - "!release-21.2*"
+      - "!release-22.1*"
+      - "!release-22.2*"
+      - "!release-23.1*"
+      - "!release-23.2*"
+      - "!staging-v22.2*"
+      - "!staging-v23.1*"
+      - "!staging-v23.2*"
   push:
     branches:
-      - 'master'
-      - 'release-*'
-      - 'staging'
-      - 'trying'
-      - '!release-1.0*'
-      - '!release-1.1*'
-      - '!release-2.0*'
-      - '!release-2.1*'
-      - '!release-19.1*'
-      - '!release-19.2*'
-      - '!release-20.1*'
-      - '!release-20.2*'
-      - '!release-21.1*'
-      - '!release-21.2*'
-      - '!release-22.1*'
-      - '!release-22.2*'
-      - '!release-23.1*'
-      - '!release-23.2*'
+      - "master"
+      - "release-*"
+      - "staging-*"
+      - "staging"
+      - "trying"
+      - "!release-1.0*"
+      - "!release-1.1*"
+      - "!release-2.0*"
+      - "!release-2.1*"
+      - "!release-19.1*"
+      - "!release-19.2*"
+      - "!release-20.1*"
+      - "!release-20.2*"
+      - "!release-21.1*"
+      - "!release-21.2*"
+      - "!release-22.1*"
+      - "!release-22.2*"
+      - "!release-23.1*"
+      - "!release-23.2*"
+      - "!staging-v22.2*"
+      - "!staging-v23.1*"
+      - "!staging-v23.2*"
 concurrency:
   group: ${{ github.head_ref || github.run_id }}
   cancel-in-progress: true
@@ -58,6 +66,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - uses: actions/upload-artifact@v4
         if: ${{ failure() }}
         with:
@@ -95,6 +105,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
@@ -136,6 +148,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
@@ -194,6 +208,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
@@ -212,6 +228,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
@@ -230,6 +248,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
@@ -248,6 +268,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
@@ -266,10 +288,12 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
-  EXPERIMENTAL_unit_tests:
+  unit_tests:
     runs-on: [self-hosted, basic_runner_group]
     steps:
       - uses: actions/checkout@v4
@@ -282,10 +306,12 @@ jobs:
       - run: ./build/github/get-engflow-keys.sh
       - run: ./build/github/prepare-summarize-build.sh
       - name: run tests
-        run: bazel test //pkg:all_tests //pkg/ui:lint //pkg/ui:test --config crosslinux --jobs 300 --remote_download_minimal --bes_keywords ci-unit-test --config=use_ci_timeouts --build_event_binary_file=bes.bin $(./build/github/engflow-args.sh)
+        run: ./build/github/unit-tests.sh
       - name: upload test results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()
@@ -304,6 +330,8 @@ jobs:
       - name: upload build results
         run: ./build/github/summarize-build.sh bes.bin
         if: always()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: clean up
         run: ./build/github/cleanup-engflow-keys.sh
         if: always()