Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fizzbuzz feedback #1

Closed
mathematicalmichael opened this issue Dec 16, 2020 · 2 comments
Closed

fizzbuzz feedback #1

mathematicalmichael opened this issue Dec 16, 2020 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@mathematicalmichael
Copy link

mathematicalmichael commented Dec 16, 2020

only one line printed per loop, so just rethink where your newlines are; you dont need to pad printouts with empty lines, this just makes for extraneous scrolling.

you leveraged the least common multiple by checking that first. good.

but now, if I asked you to switch to 7 and 2 instead of 5 and 3, you have to change code on three different lines.

do we really need three if statements?

@jordanrhall jordanrhall self-assigned this Dec 17, 2020
@jordanrhall jordanrhall added the good first issue Good for newcomers label Dec 17, 2020
@mathematicalmichael
Copy link
Author

related to the last comment: imagine your boss comes to you and says

oh, and if div by 4, throw "bizz" into the mix
i.e., fizzbizzbuzz is the longest string now

how can we do some work now to make an uncertain number of future "feature requests" easy to address? attempt to minimize the number of lines of code that need to change.

@jordanrhall
Copy link
Owner

Thanks for the suggestions and help, Michael! A function abstracting this process was the way to go.

jordanrhall pushed a commit that referenced this issue Feb 6, 2021
Added to README and showcased markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants