Fixing race condition when watching symlinks that change frequently #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When watching symlinks that change frequently this code would be unable to lstat the symlink even though the stat succeeded. I tightened this lookup to happen faster after stat and I also used the symlink? check on the return from stat instead of another File call to reduce the frequency of this race condition.
Reproduction:
Watch a symlink in tmp created like this:
touch /tmp/test_target ; ln -sf /tmp/test_target /tmp/test_link
Run this command to replace the symlink constantly and watch your tailer throw an exception while trying to grab the inode:
You will get an exception similar to this: