Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: Lintian check 'symlinks' was renamed ' #1907

Closed
jordansissel opened this issue May 27, 2022 · 1 comment · Fixed by #1939
Closed

Test failure: Lintian check 'symlinks' was renamed ' #1907

jordansissel opened this issue May 27, 2022 · 1 comment · Fixed by #1939

Comments

@jordansissel
Copy link
Owner

Problem: New test failures in the fpm deb test suite.

Context: A test that checks for #1840 by ensuring that fpm doesn't create a deb package that causes lintian to crash.

When preparing v1.14.2 for release, I noticed some new test failures that seem to be due to an upstream lintian change. As of about two years ago, lintian renamed the "symlink" check to be called "files/symbolic-links/broken"

References:

@jordansissel
Copy link
Owner Author

Thinking about how to make this test pass across different lintian versions...

Maybe just try both? If both fail, then consider it a test failure. If one succeeds, we're ok.

That is, try:

  • lintian -C symlinks ...
  • lintian -C files/symbolic-links/broken ...

If one succeeds, the test passes. If both fail, the test should fail.

As an alternative, we could check the version number and invoke the correct test, but I'm not sure exactly when lintian made this change. It seems like Lintian 2.52.0, but there's so many tags in the lintian repo it's hard to tell, and I don't know how to interpret lintian version numbers vs what's included downstream in Debian and Ubuntu. Easier probably just to try both tests and accept the one that succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant