Replace whatever in changelog.erb and deb.changes.erb #1934
Conversation
In order to support packaging upload, the distribution must be set/aligned in changelog and changes files. Required for example inside dput-ng repo upload app.
|
It will help to closes #1929 |
There was a problem hiding this comment.
Thank you for working on this!
I ran the test suite on this PR and found no new failures, nice!
That said, there's no test coverage for the .changes file nor for the changelog file either. I added one inline comment which I believe to cause a failure due, but I haven't tested this with any external Debian tools to confirm.
templates/deb/deb.changes.erb
Outdated
| @@ -14,7 +14,7 @@ Description: <%= firstline %> | |||
| <%= remainder.collect { |l| l =~ /^ *$/ ? " ." : " #{l}" }.join("\n") %> | |||
| <% end -%> | |||
| Changes: | |||
| <%= name %> (<%= "#{epoch}:" if epoch %><%= version %><%= "-" + iteration.to_s if iteration %>) whatever; urgency=medium | |||
| <%= name %> (<%= "#{epoch}:" if epoch %><%= version %><%= "-" + iteration.to_s if iteration %>) <%= distribution %>; urgency=medium | |||
There was a problem hiding this comment.
I think the leading whitespace removal will cause a breakage. Debian's changes file docs say this, from https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-changes - (Bold emphasis added by me)
The first line of the field value (the part on the same line as Changes:) is always empty. The content of the field is expressed as continuation lines, with each line indented by at least one space. Blank lines must be represented by a line consisting only of a space and a full stop (.).
There was a problem hiding this comment.
Sorry, i didnt see the missing space. It sould be ok now.
|
As i wrote on you code comment, it's should be ok with the space now. |
|
Thanks for the quick response! Change looks good :) |
|
fpm 1.15.0 is released and contains this improvement. |
In order to support packaging upload, the distribution must be set/aligned in changelog and changes files.
Required for example inside dput-ng repo upload app.