Extract the build/installation steps out of the input method for future source-based package support #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not surprised that CI tests fail considering I broke all but the cpan and gem input types. |
NicholasBHubbard
changed the title
|
I’m away from my workstation at the moment and will try to get this evaluated when I can in a week or two :) |
|
This looks like a great start :) I have some ideas and I'll shoot you a PR for them soon -- notably, changing the shell code from a multiline string to be an array of commands. I"ll also see about moving this a bit forward towards getting the test suite to pass again. |
|
I look forward to it! |
Gc6026
approved these changes
Mar 18, 2024
|
Hey @jordansissel, wondering if you ever got a chance to look at this more in depth. Best regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description of this PR provided here: #1972 (comment)