Configuration problems should print errors, not stack traces. #2067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising unexpected exceptions will often produce a crash-like behavior which prints the exception and a stack trace. Stack traces are not helpful content in situations where a user has made a configuration error.
In most cases, known configuration issues should raise either FPM::Package::InvalidArgument or FPM::InvalidPackageConfiguration. (Honestly, I have forgotten why these two exceptions aren't just a single exception type).
Before:
After: