cpan.rb - export the environment variables output by local::lib. #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordansissel
force-pushed
the
master
branch
2 times, most recently
from
715ab62
to
9866c6d
Compare
lib/fpm/package/cpan.rb
Outdated
| # The subshell call to echo is necessary because some environment | ||
| # variables are defined in terms of other such variables; this technique | ||
| # expands the variables-within-variables. | ||
| ENV[k] = `echo #{v}`.chomp |
There was a problem hiding this comment.
Thank you for the comment explaining why you do this subshell echo. I was super confused until I read the comment ❤️
|
Fixed this up to be a bit saner -- no more subshell |
by reading the `local::lib` environment variables into the current process, sans PERL_MB_OPT and PERL_MM_OPT. This helps ensure that ExtUtils::MakeMaker does not bail out with a complaint about both INSTALL_BASE and PREFIX being set. Fixes jordansissel#843.
as their test suites are flakey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #843 --
ExtUtils::MakeMakerdoesn't like it when bothPREFIXandINSTALL_BASEare defined, and some CPAN packages don't play nice with theINSTALL_BASE=trick. This pull request deals with this issue by exportinglocal::lib's environment variables into the environment of the current process prior to callingBuild.PL/Makefile.PL, skipping thePERL_MM_OPTandPERL_MB_OPTenvironment variables that were at the root of the problem.