Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 'mustache' pin #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cwegener
Copy link

Ruby 2.x are end of life.

Latest mustache 1.1.1 looks to be working just fine in my superficial
teseting on Ubuntu 22.04

Ruby 2.x are end of life.

Latest mustache 1.1.1 looks to be working just fine in my superficial
teseting on Ubuntu 22.04
@jordansissel
Copy link
Owner

While Ruby 2.x is EOL there are still many places using it, and my general approach has been to attempt backwards compatibility where possible and not to abandon old things simply because they are old or deprecated.

I’m on my phone typing this and not able to text Ruby 2.x vs 3.x for various mustache versions, nor experimenting with things like removing mustache.

I’m open to this change but not yet at the expense of losing Ruby 2.x support.

I welcome your thoughts on this :)

@cwegener
Copy link
Author

It's not a big issue for me. There will always be custom patches that I will need to maintain internally anyway. So, I'm happy to keep using a patched version with this patch applied manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants