Only attempt extraction if a known payload compressor is used. #15
+52
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to improve safety primarily to reject malicious rpms with a custom PAYLOADCOMPRESSOR tag causing arr-pm to execute arbitrary code.
The security issue was reported by Joern Schneeweisz.
An alternate implementation could be to do what rpm does in its rpmio library which is to use the C implementations of various compressor libraries. However, doing this in Ruby can cause problems because it's not always possible to compile C Ruby extensions or even install Ruby's FFI library.
Test coverage checks for accepting known payload compressors and also rejecting unknown compressor values.
Context: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/97602