Fixes and features for cmd_behave #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The effective situation was: focus and blur were synomnyms and both got fired by both window events. This commit fixes that bug.
The previous code would abort at runtime on constructs like xdotool selectwindow behave "%1" mouse-enter getactivewindow because context->windows gets freed (e.g. in window_save) ...
Also convert some messages to debug output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits fixes
(see commits for details) as well as introduces the following new features:
In case the features are not wanted, i also have a "bugfix only" branch at behave_fixes.