Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency on libXi #446

Merged
merged 1 commit into from
Oct 16, 2024

Commits on Jan 17, 2024

  1. Remove unused dependency on libXi

    In commit 6c1db90, the
    appears_to_be_wayland function was reverted (commented out, really), but
    the includes and scaffolding for it were left in. This has a couple of
    effects:
    
    - The compiler emits a warning for unused functions
    - An additional header include is used
    - The link command is longer, and tries to link to libXi, resulting in
      overlinking unless -Wl,--as-needed is used
    
    The original rationale for keeping it:
    
    > I've left the "is on wayland?" detection code that is otherwise now
    > unused, in case we want it later.
    
    The code has gone untouched for several years now, so it is probably
    time to remove it altogether. In a pinch, it can always be retrieved via
    `git log`.
    eli-schwartz committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    891be75 View commit details
    Browse the repository at this point in the history