Add in fiscal year fetch handler #421
Conversation
Fixed InFiscalYear condition expression implementation
|
@npavlov, I see green now. |
Yeah, great, thank you for the fix. 😀 |
|
Hi lads, Thanks a mill for this, since this is the first "fiscal" date time operator we're introducing, it would be good to have them work the exact same way and possibly looking at a set of properties that define how do you handle the fiscal year (I saw in the PR it's hardcoded to start from april to april, but this really varies between countries and even for the same country is up to each business decide what is going to be their fiscal year (which is normally the calendar year here in Spain for instance). So I think if we introduce a FiscalYearSettings class where we essentialy we could setup the fiscal year settings (Start Date and Period) at the very least, then all these operators could use it and be consistent and configurable for each customer. Thoughts? More info here
|
|
I would maybe add a public property to the XrmFakedContext class of the same name (FiscalYearSettings) and make these operators consume that. |
Added XrmFakedContext.FiscalYearSettings
|
|
||
| namespace FakeXrmEasy | ||
| { | ||
| [EntityLogicalName("organization")] |
There was a problem hiding this comment.
Thanks a mill for this @npavlov ! Curious to know where this EntityLogicalName was generated from... crmsvcutil or XrmToolkit or similar?
|
That's approved now @npavlov . If you could please reply to the review comment would be nice. Thanks! |
|
@npavlov also, there are other fiscal year operators. Now that that we have the implementation for InFiscalYear operator we could reuse that for the remaining fiscal year operators. I'm going to add it as a separate enhancement issue. |
|
Raised #476 for the remaining ones @npavlov @BetimBeja |
No description provided.