Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of snake-ification of mixed input #7

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

hoijui
Copy link
Contributor

@hoijui hoijui commented Nov 14, 2021

Thanks for casey! :-)
I found this issue I was having myself, and made test and patch.
I hope you find it meaningful, though very likely the code could be done better (I am still quite noob in rust).

To be honest, I was asking myself ... would it not be possible to do the actual case conversion with an other crate?
The main selling point of yours, is that ti is done at compile-time. I think, some of the others (run-time ones) around, are more used and have more tests for the case conversion, so it would be cool to make use of that, if possible.
... or is there some technical hindrance for that?

example crates:

@jordy25519
Copy link
Owner

hi @hoijui!
thanks for the PR and the tests

would it not be possible to do the actual case conversion with an other crate?

Yes handling the case conversion via a dedicated crate makes a lot of sense.
I was using heck previously but moved away from it, although can't remember the reasons.

@jordy25519 jordy25519 merged commit 13a7bf8 into jordy25519:master Nov 25, 2021
@hoijui
Copy link
Contributor Author

hoijui commented Nov 25, 2021

:D
ouh man.. I feel wit you.. that kind of thing happens to me all the time: take a decision, remember only the decision without the reasoning, and then someone wants to know why... :-)

I found the commit that removed heck, but the commit message does not mention the reason either:
b74061a

ouh well ...
thanks anyway!
for now it works for me like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants