Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GraphQL introspection instead of registry to download the schema in CI #1177

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

martinbonnin
Copy link
Collaborator

@martinbonnin martinbonnin commented Mar 8, 2024

We used to download the schema from the Apollo Registry in CI but this has proven fragile because:

  1. it requires another secret in the chain APOLLO_KEY
  2. it uncouples the endpoint from its schema
  3. it returns different formatted results than introspection, rendering useless diffs

This PR switches CI to use introspection instead. One of the drawback is that as part of this we lose applied schema directives (cf graphql/graphql-spec#300) but we're not using them so far. If we were to need them, we could use a special Query.__sdl field for that purpose.

Also set github_token to have checks run in PRs

@martinbonnin martinbonnin merged commit 5bcbfb2 into main Mar 8, 2024
5 checks passed
@martinbonnin martinbonnin deleted the use-introspection-in-ci branch March 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant