Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update github actions #101

Merged
merged 1 commit into from
Aug 25, 2023
Merged

ci: update github actions #101

merged 1 commit into from
Aug 25, 2023

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Aug 14, 2023

This PR bumps GitHub Actions to their latest major versions, which now use Node 16 internally instead of Node 12 (EOL as of end of April 2022, no longer receives security updates):

  • Changelog for actions/checkout can be found here
  • Releases for actions/setup-node can be found here

@jorgebucaran
Copy link
Owner

Apologies for the delay here, any insight on why the CI failed?

@Fdawgs
Copy link
Contributor Author

Fdawgs commented Aug 21, 2023

Apologies for the delay here, any insight on why the CI failed?

No worries!

It's due to the prepare script calling the build script, which then runs npx rollup. Rollup dropped support for anything under Node 14.18.x with v3.0.0. So Node 14 will pass (seen here) but the legacy Node versions will fail.

It seems this has already caused previous jobs to fail.

I guess either the EOL versions of Node need to be dropped from CI, or rollup needs to be pinned to a version before v3?

@jorgebucaran jorgebucaran merged commit 0928e67 into jorgebucaran:main Aug 25, 2023
@Fdawgs Fdawgs deleted the ci/versions branch August 25, 2023 20:01
@jorgebucaran
Copy link
Owner

@kibertoad Does it make sense to remove EOL versions from the workflow already?

@kibertoad
Copy link
Collaborator

@jorgebucaran Sure! Let's bump colorette to semver major then, as it would mean we no longer promise backwards compatibility

@jorgebucaran
Copy link
Owner

Wouldn't that be less straightforward initially? Our first step could be to remove the EOL versions from the workflow, which is a simple change aimed solely at fixing the build (currently broken for 10.x and 12.x due to #101).

@kibertoad
Copy link
Collaborator

right, so we already don't support them. sure, let's just remove them then

@jorgebucaran
Copy link
Owner

I get what you're saying. By upgrading to GitHub Actions 3, we officially don't support 10.x and 12.x, although Colorette still works with these versions.

@kibertoad
Copy link
Collaborator

Well yeah, if our CI is not working, we can't be sure if these versions didn't break at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants