Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isColorSupported is showing TRUE for non-tty Windows terminals #97

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

isColorSupported is showing TRUE for non-tty Windows terminals #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26917ba
Check TTY support for windows terminals
Azatey Jan 4, 2023
bf09466
Merge pull request #1 from Azatey/windows-no-tty-color-support-fix
Azatey Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,18 @@ const isForced = "FORCE_COLOR" in env || argv.includes("--color")
const isWindows = platform === "win32"
const isDumbTerminal = env.TERM === "dumb"

const isTty = tty && tty.isatty && tty.isatty(1)

const isCompatibleTerminal =
tty && tty.isatty && tty.isatty(1) && env.TERM && !isDumbTerminal
isTty && env.TERM && !isDumbTerminal

const isCI =
"CI" in env &&
("GITHUB_ACTIONS" in env || "GITLAB_CI" in env || "CIRCLECI" in env)

export const isColorSupported =
!isDisabled &&
(isForced || (isWindows && !isDumbTerminal) || isCompatibleTerminal || isCI)
(isForced || (isWindows && !isDumbTerminal && isTty) || isCompatibleTerminal || isCI)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we achieve the same result by checking isCompatibleTerminal earlier?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not, isCompatibleTerminal will return false both when run through non-TTY GUI app and when through command line directly on Windows. And it seems like Windows console is never TTY either while checked through nodejs.


const replaceClose = (
index,
Expand Down