Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a plugin emits *_uninstall event #526

Closed
jorgebucaran opened this issue Feb 14, 2019 · 2 comments
Closed

Updating a plugin emits *_uninstall event #526

jorgebucaran opened this issue Feb 14, 2019 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@jorgebucaran
Copy link
Owner

jorgebucaran commented Feb 14, 2019

We should be able to update plugins without removing them first.

Related: jethrokuan/fzf#107

@jorgebucaran jorgebucaran added the bug Something isn't working label Feb 14, 2019
@jorgebucaran jorgebucaran added this to the 3.3.0 milestone Feb 23, 2019
@jorgebucaran jorgebucaran modified the milestone: 4.0.0 Nov 2, 2020
@jorgebucaran
Copy link
Owner Author

Fisher will now fire a foobar_update event for plugins being updated.

@jorgebucaran jorgebucaran changed the title Updating a package emits *_uninstall event Updating a plugins emits *_uninstall event Nov 2, 2020
@jorgebucaran jorgebucaran changed the title Updating a plugins emits *_uninstall event Updating a plugin emits *_uninstall event Nov 2, 2020
jorgebucaran added a commit that referenced this issue Nov 2, 2020
`_update`. Starting with 4.0 plugin authors should
be able to reliably know when their plugin is installed,
updated, or uninstalled. Related #526, #527 #573.

- Remove "some" OMF plugin support (it won't go away completely
since more than less of OMF plugins actually work fine).
This means fully deprecating `init.fish`, `uninstall.fish`,
etc. So long, and thanks for all the fish! Related: #581

- No cache fallback, no plugin dependencies, no more private
package hosts, and no more gitlab/bitbucket support. #464, #579
- Require fish 3.0, use newer fish features, e.g., use `wait` to
implement concurrent downloads.
- Rely less on external tools. No awk, no sed, no basename/dirname.
Just mv, rm, cp, and mkdir.

Deprecate `fishfile` in favor of `fish_plugins`. This new file
works like the old fishfile, but without comment support. See #524.
jorgebucaran added a commit that referenced this issue Nov 2, 2020
- Introduce event system. #526, #527 #573.
- Deprecate `init.fish`, `uninstall.fish`, etc. #581
- No cache fallback, no plugin dependencies, no more private
package hosts, and no more gitlab/bitbucket support. #464, #579
- Require fish 3.0, use newer fish features, e.g., use `wait` to
implement concurrent downloads.
- Rely less on external tools. No awk, no sed, no basename/dirname.
Just mv, rm, cp, and mkdir.
- Deprecate `fishfile` in favor of `fish_plugins`. This new file
works like the old fishfile, but without comment support. See #524.
@jorgebucaran jorgebucaran mentioned this issue Nov 2, 2020
jorgebucaran added a commit that referenced this issue Nov 4, 2020
- Introduce new event system. #526, #527 #573.
- Deprecate `init.fish`, `uninstall.fish`, etc. #581
- No cache fallback, no plugin dependencies, no more private
package hosts, and no more gitlab/bitbucket support. #464, #579
- Require fish 3.0, use newer fish features, e.g., use `wait` to
implement concurrent downloads.
- Rely less on external tools. No awk, no sed, no basename/dirname.
Just mv, rm, cp, and mkdir.
- Deprecate `fishfile` in favor of `fish_plugins`. This new file
works like the old fishfile, but without comment support. See #524.
@jorgebucaran
Copy link
Owner Author

Implemented in 4.x. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant