Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent subcommand names/terminology #593

Closed
jorgebucaran opened this issue Nov 2, 2020 · 5 comments
Closed

More consistent subcommand names/terminology #593

jorgebucaran opened this issue Nov 2, 2020 · 5 comments
Milestone

Comments

@jorgebucaran
Copy link
Owner

We talk about installing and removing plugins, but use add and rm. ls to list, and usually just run fisher to update (not exactly #527). This can be confusing. Starting in 4.0, I invoke fish's law of discoverability and plan to deprecate add, ls, and rm, in favor of install, update, list, and remove.

  • fisher addfisher install
  • fisherfisher update
  • fisher rmfisher remove
  • fisher lsfisher list

Thank fish for autocompletion, it's not like we have to type all that every time, e.g., fisher i + Tab will autocomplete install for you and so on.

@jorgebucaran jorgebucaran added this to the 4.0.0 milestone Nov 2, 2020
@jorgebucaran
Copy link
Owner Author

Implemented in 4.x. 🎉

adipurnamk added a commit to adipurnamk/fish_logo that referenced this issue Nov 21, 2020
As the issue at jorgebucaran/fisher#593, 
Starting in v4.0, the 'add' command has been replaced by 'install'
@nirvdrum
Copy link

Are the old commands still supposed to work? The 4.0 release notes say fish add was deprecated, but using it errors out with "fisher: unknown flag or command: "add" (see fisher -h)".

@jorgebucaran
Copy link
Owner Author

@nirvdrum I suppose you are using the latest Fisher? add and rm were deprecated in 4.0, and no longer work on 4.1. 😉

@nirvdrum
Copy link

Okay. I thought maybe it was a bug because there's no mention in the 4.1 release notes about them being removed. Deprecating in a major version and then removing in the very next minor version (released only five days later) caught me off-guard. I'll update my Ansible config to lock down the fisher version better.

@jorgebucaran
Copy link
Owner Author

@nirvdrum there's no mention in the 4.1 release notes about them being removed

Good point. Just added a note. 👍

mrcodekiddie pushed a commit to mrcodekiddie/fish-jabba that referenced this issue Feb 19, 2022
Deprecated add, ls, and rm in favor of install, list, and remove respectively ([#593] (jorgebucaran/fisher#593)) on release 4.0.0.


![It ain't much,but it's honest work meme](https://i.kym-cdn.com/entries/icons/mobile/000/028/021/work.jpg "It ain't much,but it's honest work")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants