Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating shouldn't remove plugin if the host is unvailable #602

Closed
jorgebucaran opened this issue Nov 9, 2020 · 0 comments
Closed

Updating shouldn't remove plugin if the host is unvailable #602

jorgebucaran opened this issue Nov 9, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
4.1.0

Comments

@jorgebucaran
Copy link
Owner

If fisher update foo/bar fails, we shouldn't remove the plugin as that would be the worst possible outcome for the user. Imagine trying to update a plugin and not only failing to do that, but the plugin it's removed. Related #601.
@jorgebucaran jorgebucaran added the bug Something isn't working label Nov 9, 2020
@jorgebucaran jorgebucaran added this to the 4.1.0 milestone Nov 9, 2020
jorgebucaran added a commit that referenced this issue Nov 9, 2020
@jorgebucaran
4.1.0
5a81014 
- Remove and install when updating instead of replacing files (#601)
- Updating shouldn't remove plugin if the host is unvailable (#602)
- Can't reliably update local plugins because of symlinks (#603)
- Filter duplicates in argv and fish_plugins (#604)
- Add support to install plugins from branch names with slashes (#588)
@jorgebucaran jorgebucaran mentioned this issue Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
1 participant
@jorgebucaran