-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use current fish path instead of fish command #716
Conversation
@IlanCosman This requires at least what version of Fish? |
Do you mean when did And I'm pretty sure |
set --local source (command mktemp -d) | ||
set --append source_plugins $source | ||
|
||
command mkdir -p $source/{completions,conf.d,functions} | ||
|
||
fish --command " | ||
$fish_path --command " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this also Fish 3.0 or was it introduced more recently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this has been around for a while now. Just checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faho Sorry to bother but would you happen to know when variable-in-command-position was released? Tried combing through the release notes but couldn't find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this is in since 3.0 as well! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will merge here and release tomorrow! Thanks.
Doesn't brew put Fish in your PATH? I install Fish via brew too and I've never had to do that. Or I could've added it myself and forgotten about it. 😅 |
|
Yes. Then I must have added it to my PATH. Makes sense. 👍 |
fish
may not be an available command, for example if it was installed throughbrew
. Whenever Irm -r ~/.config/fish/
on my mac (for developing Tide), I have tofish_add_path /opt/homebrew/bin/
before I run myfisher
command. Instead, lets just guarantee a valid command by using the path to the current instance of fish. Tide already does this and it has worked fine so far.