Fix a compatibility issue with fish 3.0.x #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a docker image that can install fish, but it is verison 3.0.2. The bash-compatible mechnism of `fish_path=(status fish-path) command` was not added until after 3.0.2, probably 3.1. By setting `fish_path` *earlier* in the fuction, Fisher has full compatibility with this earlier version of Fish 3.
jorgebucaran
approved these changes
Jun 17, 2022
|
Thank you, @halostatue, perfectly done. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a docker image that can install fish, but it is verison 3.0.2. The bash-compatible mechnism of
fish_path=(status fish-path) commandwas not added until after 3.0.2, probably 3.1. By settingfish_pathearlier in the fuction, Fisher has full compatibility with this earlier version of Fish 3.