Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiline prompt not working #29

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Fix multiline prompt not working #29

merged 1 commit into from
Feb 28, 2022

Conversation

bobsoppe
Copy link
Contributor

With 83c6f26 the multiline prompt got broken.

Normally echo will not parse the \n used to get the multiline prompt to work. Using string unescape should solve this and also keep the intended change of 83c6f26

@jorgebucaran
Copy link
Owner

Thanks, @bobsoppe. Are you sure this doesn't break #27?

@bobsoppe
Copy link
Contributor Author

I think that would indeed break #27.
But we also could add the -e flag to the echo to solve this problem

image

@jorgebucaran
Copy link
Owner

Yes, maybe that'll do it! 👍

@bobsoppe
Copy link
Contributor Author

Gently pinging @jorgebucaran ☺️

@jorgebucaran jorgebucaran added the enhancement New feature or request label Feb 28, 2022
@jorgebucaran jorgebucaran merged commit d487506 into jorgebucaran:main Feb 28, 2022
@jorgebucaran
Copy link
Owner

My bad, it's in! 🙆‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobsoppe @jorgebucaran