Allow update to take a reducer. #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgebucaran
requested review from
lukejacksonn,
zaceno,
okwolf,
andyrj and
MatejBransky
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 148 149 +1
Branches 45 46 +1
=====================================
+ Hits 148 149 +1
Continue to review full report at Codecov.
|
okwolf
reviewed
Sep 1, 2017
| @@ -8,7 +8,7 @@ yarn.lock | |||
| package-lock.json | |||
|
|
|||
| # Misc | |||
| sandbox | |||
| example | |||
There was a problem hiding this comment.
We're not using either of these are we?
There was a problem hiding this comment.
@okwolf I am locally, but it's not committed to the repo.
jorgebucaran
force-pushed
the
thunks/state
branch
from
2b35ff2 to
a4fe3f1
Compare
Inside a thunk, update usually takes a partial state and
merges it with the previous state producing a new state.
This commit extends update to also take a function that
we will immediately call with the latest state and like
an action/reducer, allows you to update the state by
returning a partial state.
You'd want to use this feature when you need to update
the state inside an async process and you are not sure
whether the state that was passed to the action that
started the async process has become out-of-date or not.
A reducer is a function that receives the state and returns
a partial state (or a reducer :mindblow:).
actions: {
someAyncAction(state) {
return update => {
longTaskWithCallback(someData, () =>
update(state => ({ value: state.value + 1 }))
)
}
}
}
This allows you to get the current & latest state inside the
callback of some async call.
jorgebucaran
force-pushed
the
thunks/state
branch
from
a4fe3f1 to
6aeae79
Compare
|
Updated docs and added 100% coverage. I'd like to merge here and now work on a substantial docs update. 🔥 |
|
Related zaceno/hyperapp-partial#3 |
jorgebucaran
added a commit
that referenced
this pull request
Jan 7, 2018
Inside a thunk, update usually takes a partial state and
merges it with the previous state producing a new state.
This commit extends update to also take a function that
we will immediately call with the latest state and like
an action/reducer, allows you to update the state by
returning a partial state.
You'd want to use this feature when you need to update
the state inside an async process and you are not sure
whether the state that was passed to the action that
started the async process has become out-of-date or not.
A reducer is a function that receives the state and returns
a partial state (or a reducer :mindblow:).
actions: {
someAyncAction(state) {
return update => {
longTaskWithCallback(someData, () =>
update(state => ({ value: state.value + 1 }))
)
}
}
}
This allows you to get the current & latest state inside the
callback of some async call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reducer is a function that takes the state and returns a new state or a reducer.
This allows you to get the current & latest state inside the callback of some async call.
The alternative is using the state that was passed to the action that originated the async call. The problem is that this reference to the state may have gone out-of-date if other actions run and finished during the async process and changed the state.