-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the default root element and initial render after the document is ready #64
Conversation
Codecov Report@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 40.55% 41.37% +0.81%
==========================================
Files 3 3
Lines 143 145 +2
==========================================
+ Hits 58 60 +2
Misses 85 85
Continue to review full report at Codecov.
|
I might need to make a slight mod to rebase with the changes made in 4126833. |
Playing devil's advocate here: why is it safest? and also, how come we were not getting any errors until now? That could be indicating a deeper problem. |
@jbucaran If that's helpful I definitely already had that issue in |
@dodekeract Minor correction, it's |
The reason I made the change was strictly due to potential timing issues. If your JS runs in the |
Yup. 😅 |
Just posted a comment with example in #69. |
What do other frameworks usually do here? Does anybody know? |
@jbucaran React definitely doesn't work/do this, because you have to manually give Now that we're talking about that - is it supported to render directly to |
@dodekeract Try |
Root elements, subscriptions and initial render (incl. router support) landed in master. Thank you @tzellman for bringing this up! |
It seems safest to wait until the document is ready before we attempt to:
render