Allow setting nvm's custom install directory

[davychhouk]

Description:

Allow setting nvm's custom install directory.

If $nvm_data is set, it would use this path as the install directory.
Otherwise default to $XDG_DATA_HOME.

Changes:

• Only set $nvm_data to $XDG_DATA_HOME if $nvm_data is not set.
• Update README.md detailing how to set $nvm_data.
• Update help command to show $nvm_data variable.

Ref: #146

[jorgebucaran]

Thank you! I'll take a little time to think it over and decide if I want to go for it or not.

[smorimoto]

I really want this!

[smorimoto]

You have to add that variable here:

nvm.fish/functions/nvm.fish

Lines 47 to 51 in a0892d0

	echo "Variables:"
	echo " nvm_arch Override architecture, e.g. x64-musl"
	echo " nvm_mirror Use a mirror for downloading Node binaries"
	echo " nvm_default_version Set the default version for new shells"
	echo " nvm_default_packages Install a list of packages every time a Node version is installed"

[davychhouk]

I've updated the help desc.

[jorgebucaran]

How about calling it nvm_data instead of nvm_dir?

[davychhouk]

This makes sense, I've refactored the changes.
Please have a look. Thanks!

[smorimoto]

The latest branch is unable to resolve the version with the default node version variable.

[davychhouk]

It should be good now.
If there is a better way to do this, please let me know.
Thanks!

[jorgebucaran]

LGTM :)

[smorimoto]

🎉

[smorimoto]

Oops, it still does not seem to resolve the default version 🤷‍♂️

[davychhouk]

Ohh really?
My quick test, it was working. Let me double-check again then.

[jorgebucaran]

This PR enables a simpler way to customize the data directory. It does not affect the default version, or did I misunderstand you?

[smorimoto]

If set globally, it will not work.

Suggested change

	set --global nvm_data ~/.nvm
	set --universal nvm_data ~/.nvm

[jorgebucaran]

What will not work exactly?

[jorgebucaran]

You need to put it in your config.fish. Unless we intended this feature to work interactively, which I did not assume.

[smorimoto]

It causes the following error:

nvm: Can't use Node "22", version must be installed first

[smorimoto]

Of course I added that to config.fish, but it did not work unless I set it as universal.

[jorgebucaran]

I see, thanks. I'll investigate then!

[smorimoto]

It may have been shadowed by setting the variable in different ways.

[smorimoto]

I don't know why only global does not work with the default version, but this seems like the reason.

# Blow up everything
set --erase --universal --global nvm_data

# This does not work...
set --global nvm_data $HOME/.nvm

# Blow up again
set --erase --global nvm_data

# This works
set --universal nvm_data $HOME/.nvm

[smorimoto]

Anyway, just update the documentation and then we can go ahead!

[smorimoto]

Oops, wait, now it works. There is a possibility that I made a mistake in the somewhere.

[smorimoto]

You may also have to update the documentation to set nvm_default_version and nvm_default_packages globally, not universally.

[jorgebucaran]

We need one of those to be universal when setting the default version for new shells because your config.fish is sourced last.

[smorimoto]

I actually had to set both the default version and the data directory as universal.

[jorgebucaran]

I'll investigate.

[smorimoto]

Thanks a lot!