Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Commit

Permalink
Trying against emkornfield integration tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgecarleitao committed Aug 31, 2021
1 parent 15d3657 commit eda9c6e
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 1 deletion.
2 changes: 1 addition & 1 deletion integration-testing/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ publish = false
logging = ["tracing-subscriber"]

[dependencies]
arrow2 = { path = "../", features = ["io_ipc", "io_json_integration"], default-features = false }
arrow2 = { path = "../", features = ["io_ipc", "io_ipc_compression", "io_json_integration"], default-features = false }
arrow-flight = { path = "../arrow-flight" }
async-trait = "0.1.41"
clap = "2.33"
Expand Down
55 changes: 55 additions & 0 deletions integration-testing/unskip.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
diff --git a/dev/archery/archery/integration/datagen.py b/dev/archery/archery/integration/datagen.py
index d0c4b3d6c..5f065e0ea 100644
--- a/dev/archery/archery/integration/datagen.py
+++ b/dev/archery/archery/integration/datagen.py
@@ -1568,8 +1568,7 @@ def get_generated_json_files(tempdir=None):
.skip_category('Go') # TODO(ARROW-7901)
.skip_category('JS'), # TODO(ARROW-7900)

- generate_decimal128_case()
- .skip_category('Rust'),
+ generate_decimal128_case(),

generate_decimal256_case()
.skip_category('Go') # TODO(ARROW-7948): Decimal + Go
@@ -1579,13 +1578,11 @@ def get_generated_json_files(tempdir=None):
generate_datetime_case(),

generate_interval_case()
- .skip_category('JS') # TODO(ARROW-5239): Intervals + JS
- .skip_category('Rust'),
+ .skip_category('JS'), # TODO(ARROW-5239): Intervals + JS,

generate_month_day_nano_interval_case()
.skip_category('Go')
- .skip_category('JS')
- .skip_category('Rust'),
+ .skip_category('JS'),


generate_map_case()
@@ -1603,8 +1600,7 @@ def get_generated_json_files(tempdir=None):

generate_nested_large_offsets_case()
.skip_category('Go')
- .skip_category('JS')
- .skip_category('Rust'),
+ .skip_category('JS'),

generate_unions_case()
.skip_category('Go')
diff --git a/dev/archery/archery/integration/runner.py b/dev/archery/archery/integration/runner.py
index 6f4c1385a..b46597232 100644
--- a/dev/archery/archery/integration/runner.py
+++ b/dev/archery/archery/integration/runner.py
@@ -132,10 +132,8 @@ class IntegrationRunner(object):
skip.add("Go")
skip.add("Java")
skip.add("JS")
- skip.add("Rust")
if prefix == '2.0.0-compression':
skip.add("JS")
- skip.add("Rust")

# See https://github.com/apache/arrow/pull/9822 for how to
# disable specific compression type tests.
3 changes: 3 additions & 0 deletions src/ffi/schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ fn to_format(data_type: &DataType) -> String {
DataType::Duration(TimeUnit::Nanosecond) => "tDn".to_string(),
DataType::Interval(IntervalUnit::YearMonth) => "tiM".to_string(),
DataType::Interval(IntervalUnit::DayTime) => "tiD".to_string(),
DataType::Interval(IntervalUnit::MonthDayNano) => {
todo!("Spec for FFI for MonthDayNano still not defined.")
}
DataType::Timestamp(unit, tz) => {
let unit = match unit {
TimeUnit::Second => "s".to_string(),
Expand Down

0 comments on commit eda9c6e

Please sign in to comment.