Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add wrapping versions for arithmetics. #472

Closed
yjhmelody opened this issue Sep 30, 2021 · 1 comment · Fixed by #496
Closed

Add wrapping versions for arithmetics. #472

yjhmelody opened this issue Sep 30, 2021 · 1 comment · Fixed by #496
Labels
feature A new feature good first issue Good for newcomers no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@yjhmelody
Copy link
Contributor

yjhmelody commented Sep 30, 2021 •
edited
Loading

For add op, arrow2 already has add/checked_add/saturating_add/overflowing_add versions.

If wrapping_add can be supported, then when the user does not need to consider overflow, this operation will neither panic nor affect performance.

If you agree, I will try to implement this later.
@jorgecarleitao jorgecarleitao changed the title Consider wrapping version for arithmetics. Add wrapping versions for arithmetics. Sep 30, 2021
@jorgecarleitao jorgecarleitao added feature A new feature good first issue Good for newcomers labels Sep 30, 2021
@jorgecarleitao
Copy link
Owner

Makes a lot of sense. 👍

@jorgecarleitao jorgecarleitao mentioned this issue Oct 8, 2021
Merged
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature A new feature good first issue Good for newcomers no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added wrapping version arithmetics for PrimitiveArray yjhmelody/arrow2
2 participants
@jorgecarleitao @yjhmelody