Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added wrapping version arithmetics for PrimitiveArray #496

Merged
merged 8 commits into from
Oct 8, 2021

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Oct 8, 2021

Closes #472

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #496 (6efa460) into main (4bb3237) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   80.20%   80.17%   -0.03%     
==========================================
  Files         381      381              
  Lines       23653    23659       +6     
==========================================
- Hits        18970    18969       -1     
- Misses       4683     4690       +7     
Impacted Files Coverage Δ
src/compute/arithmetics/basic/add.rs 95.83% <0.00%> (-4.17%) ⬇️
src/compute/arithmetics/basic/mul.rs 95.83% <0.00%> (-4.17%) ⬇️
src/compute/arithmetics/basic/sub.rs 95.83% <0.00%> (-4.17%) ⬇️
src/compute/arithmetics/mod.rs 24.70% <ø> (ø)
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (-1.50%) ⬇️
src/io/ipc/write/common.rs 75.64% <0.00%> (-0.65%) ⬇️
src/io/avro/read/schema.rs 55.95% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb3237...6efa460. Read the comment docs.

@yjhmelody yjhmelody marked this pull request as ready for review October 8, 2021 04:33
Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless. Less some minor nits to the docs, but otherwise ready to go!

src/compute/arithmetics/basic/add.rs Outdated Show resolved Hide resolved
src/compute/arithmetics/basic/add.rs Outdated Show resolved Hide resolved
src/compute/arithmetics/basic/add.rs Outdated Show resolved Hide resolved
src/compute/arithmetics/basic/add.rs Outdated Show resolved Hide resolved
src/compute/arithmetics/basic/mul.rs Outdated Show resolved Hide resolved
yjhmelody and others added 5 commits October 8, 2021 13:50
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
@yjhmelody
Copy link
Contributor Author

Yes, I haved updated the docs according your suggestions.
BTW, some comments are based on the original style, such as adding comments for some trait implementations (I don’t think it is necessary too)

@jorgecarleitao jorgecarleitao merged commit 9163616 into jorgecarleitao:main Oct 8, 2021
@jorgecarleitao jorgecarleitao added the feature A new feature label Oct 8, 2021
@jorgecarleitao jorgecarleitao changed the title Add Wrapping version ops for primitiveArray Added wrapping version arithmetics for PrimitiveArray Oct 8, 2021
@yjhmelody yjhmelody deleted the wrapping-arith branch October 8, 2021 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wrapping versions for arithmetics.
2 participants